Re: [PATCH] FreeBSD add functionality to build PIE executables.

[Andreas Tobler <andreast-list at fgznet dot ch>]

On 18.05.15 19:36, Jeff Law wrote:
> On 05/17/2015 02:42 PM, Andreas Tobler wrote:
> > Ping?!
> >
> > Thanks,
> > Andreas
> >
> > On 11.05.15 22:34, Andreas Tobler wrote:
> > > All,
> > >
> > > this patch adds the ability to build PIE executables for FreeBSD. The
> > > core is since a longer time in the code base of FreeBSD itself and is
> > > working fine.
> > >
> > > This patch makes it available for all FreeBSD targets.
> > > Tested on x86_64-*-freebsd11.0 and armv6/hf-*-freebsd11.0,
> > > i386-*-freebsd11.0 is progress.
> > >
> > > In the same turn I removed the STARTFILE/ENDFILE_SPEC from
> > > config/i386/freebsd.h and use the ones from config/freebsd-spec.h.
> > >
> > > Here the results before the patch:
> > >
> > > https://gcc.gnu.org/ml/gcc-testresults/2015-05/msg01267.html
> > >
> > > and with the patch:
> > >
> > > https://gcc.gnu.org/ml/gcc-testresults/2015-05/msg01324.html
> > >
> > > Is this ok for trunk and for 5.1X?
> > >
> > > Thanks,
> > > Andreas
> > >
> > > 2015-05-11  Andreas Tobler  <andreast@gcc.gnu.org>
> > >
> > >      * config/freebsd-spec.h (FBSD_STARTFILE_SPEC): Add the bits to build
> > >      pie executables.
> > >      (FBSD_ENDFILE_SPEC): Likewise.
> > >      * config/i386/freebsd.h (STARTFILE_SPEC): Remove and use the one from
> > >      config/freebsd-spec.h.
> > >      (ENDFILE_SPEC): Likewise.
> > >
> > > 2015-05-11  Andreas Tobler  <andreast@gcc.gnu.org>
> > >
> > >      * lib/target-supports.exp (check_effective_target_pie): Add
> > > *-*-freebsd*
> > >      to the familiy of pie capable targets.
> OK for the trunk, please install.  Release managers have final say for
> the release branches.


Done.

Thanks for the review.
Andreas