This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR65915] Fix float conversion split.
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 5 May 2015 15:12:54 +0200
- Subject: Re: [PATCH, PR65915] Fix float conversion split.
- Authentication-results: sourceware.org; auth=none
- References: <20150319092404 dot GA73948 at msticlxl7 dot ims dot intel dot com> <20150323160222 dot GB10265 at msticlxl7 dot ims dot intel dot com> <20150324134311 dot GA40649 at msticlxl57 dot ims dot intel dot com> <20150428162049 dot GA62528 at msticlxl7 dot ims dot intel dot com> <20150430151512 dot GA106194 at msticlxl7 dot ims dot intel dot com> <CAMe9rOoqMpxNVGHgBK8+8CB-psVxGKY=J3kY=3DsTKo+OqR-Ng at mail dot gmail dot com> <CAFULd4aAAQjJvNpUUdxkVZVi7iOGwMsvP-zevb4uP70Uz7HsXQ at mail dot gmail dot com> <20150505130324 dot GA47477 at msticlxl7 dot ims dot intel dot com>
On Tue, May 5, 2015 at 3:03 PM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> >> +++ b/gcc/testsuite/gcc.target/i386/pr65915.c
>> >> @@ -0,0 +1,6 @@
>> >> +/* { dg-do run } */
>> >> +/* { dg-options "-O2 -mavx512f -fpic -mcmodel=medium" } */
>> >> +/* { dg-require-effective-target avx512f } */
>> >> +/* { dg-require-effective-target lp64 } */
>> >> +
>> >> +#include "avx512f-vrndscalepd-2.c"
>> >
>> > Missing testcases for
>> >
>> > FAIL: gcc.target/i386/avx512f-vrndscaleps-2.c (test for excess errors)
>> > FAIL: gcc.target/i386/avx512vl-vrndscaleps-2.c (internal compiler error)
>>
>> The attached test is OK, since these two would test for the same problem.
>>
>> > as well as ChangeLog entries.
>>
>> ChangeLog is missing. Please add PR number and describe *each* change
>> accurately. You can say (vector convert to float spltiter) for this
>> particular nameless splitter.
>>
>> Please repost the patch with updated ChangeLog.
>>
>
> ChangeLog
>
> PR c/65915
> * config/i386/i386.md (vector convert to float spltiter): Check for
> xmm16+, when splitting scalar float conversion.
> * config/i386/sse.md (sse2_cvtsi2sd): Support EVEX version.
>
> And for tests
>
> PR c/65915
> * gcc.target/i386/pr65915.c: New.
OK for mainline.
Thanks,
Uros.