This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()

From: Jeff Law <law at redhat dot com>
To: Max Filippov <jcmvbkbc at gmail dot com>
Cc: Chen Gang S <gang dot chen at sunrus dot com dot cn>, Steven Bosscher <stevenb dot gcc at gmail dot com>, Sterling Augustine <augustine dot sterling at gmail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Richard Henderson <rth at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Tue, 24 Feb 2015 15:48:56 -0700
Subject: Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
Authentication-results: sourceware.org; auth=none
References: <54E99B0E dot 2080109 at sunrus dot com dot cn> <54EBA926 dot 30207 at redhat dot com> <CABu31nPrpNmLQapXcu_XF0S12DKM27eVrTJ9GER=eN6oo=L7VA at mail dot gmail dot com> <54EBB454 dot 9000601 at redhat dot com> <54EBD4ED dot 4080605 at sunrus dot com dot cn> <54EC9ECE dot 8030709 at redhat dot com> <CAMo8BfJKGAvY-JeK0hJiHxeuqm4QWYgH0ON_m-vrGbe2A8v+4A at mail dot gmail dot com>

On 02/24/15 15:05, Max Filippov wrote:

Hi,

On Tue, Feb 24, 2015 at 6:54 PM, Jeff Law <law@redhat.com> wrote:


You can tackle them in any order you wish.  However, I suspect fixing the
xtensa backend may be easier.  I don't have any good way to test xtensa, but
something like the attached patch for the xtensa port should be sufficient.


I can confirm that this patch fixes the issue. I haven't got a segfault
as was reported in bugzilla, but I got some 'conditional jump or move
depends on uninitialised value' under valgrind, originated from
find_reloads, that the patch fixed. And with it the testcase from
bugzilla actually produces code with loop instruction.

OK. I'll go ahead and commit it. And yes, it should be fixing the"conditional jump or move depends on uninitialized value" errors infind_reloads as reported by valgrind.


Jeff

References:
- [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
  - From: Chen Gang S
- Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
  - From: Jeff Law
- Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
  - From: Steven Bosscher
- Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
  - From: Jeff Law
- Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
  - From: Chen Gang S
- Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
  - From: Jeff Law
- Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
  - From: Max Filippov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]