This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
- From: Chen Gang S <gang dot chen at sunrus dot com dot cn>
- To: Jeff Law <law at redhat dot com>, Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: augustine dot sterling at gmail dot com, "Joseph S. Myers" <joseph at codesourcery dot com>, Richard Henderson <rth at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 24 Feb 2015 09:33:33 +0800
- Subject: Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()
- Authentication-results: sourceware.org; auth=none
- References: <54E99B0E dot 2080109 at sunrus dot com dot cn> <54EBA926 dot 30207 at redhat dot com> <CABu31nPrpNmLQapXcu_XF0S12DKM27eVrTJ9GER=eN6oo=L7VA at mail dot gmail dot com> <54EBB454 dot 9000601 at redhat dot com>
On 2/24/15 07:14, Jeff Law wrote:
> On 02/23/15 16:09, Steven Bosscher wrote:
>>>
>>>
>>> Which violate the rule for matching constraints.
>>
>> ...and should never have worked at all...
> Yup. It's only been fairly recently that we started statically checking MD files in any significant way -- we've still got a long way to go I'm sure.
>
OK, thanks. I shall try to finish within this month (although I am not
quite sure whether I can finish on time).
>>
>>
>>> I'm confident that if the xtensa's patterns were fixed to abide by the rules
>>> for matching constraints the problem in reload would not occur.
>>
>>
>> Chen, perhaps a warming can be implemented for this in genrecog?
> That would certainly be a welcome addition!
>
OK, thanks. May I firstly finish it before fixing xtensa pattern? I
guess it is more easier than fixing xtensa patten. (I guess 'warming' is
'warning'.)
By the way, can this patch "initialize several arrays before use them in
find_reloads()" will cause correctness issue? (I guess not, it will skip
optimization, but not cause correctness issue, and continue compiling).
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed