This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()


On 2/24/15 07:14, Jeff Law wrote:
> On 02/23/15 16:09, Steven Bosscher wrote:
>>>
>>>
>>> Which violate the rule for matching constraints.
>>
>> ...and should never have worked at all...
> Yup.  It's only been fairly recently that we started statically checking MD files in any significant way -- we've still got a long way to go I'm sure.
> 

OK, thanks. I shall try to finish within this month (although I am not
quite sure whether I can finish on time).

>>
>>
>>> I'm confident that if the xtensa's patterns were fixed to abide by the rules
>>> for matching constraints the problem in reload would not occur.
>>
>>
>> Chen, perhaps a warming can be implemented for this in genrecog?
> That would certainly be a welcome addition!
> 

OK, thanks. May I firstly finish it before fixing xtensa pattern?  I
guess it is more easier than fixing xtensa patten. (I guess 'warming' is
'warning'.)


By the way, can this patch "initialize several arrays before use them in
find_reloads()" will cause correctness issue? (I guess not, it will skip
optimization, but not cause correctness issue, and continue compiling).



Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]