Re: [patch] omp-low.h

[Andrew MacLeod <amacleod at redhat dot com>]

On 10/17/2013 11:15 AM, Jakub Jelinek wrote:
> > *************** struct omp_for_data
> > *** 135,141 ****
> >    static splay_tree all_contexts;
> >    static int taskreg_nesting_level;
> >    static int target_nesting_level;
> > ! struct omp_region *root_omp_region;
> >    static bitmap task_shared_vars;
> >    
> >    static void scan_omp (gimple_seq *, omp_context *);
> > --- 175,181 ----
> >    static splay_tree all_contexts;
> >    static int taskreg_nesting_level;
> >    static int target_nesting_level;
> > ! static struct omp_region *root_omp_region;
> >    static bitmap task_shared_vars;
> >    
> >    static void scan_omp (gimple_seq *, omp_context *);
> Why?
It should be static now since it is no longer exported outside the 
file... and can't be now that struct omp_region is declared in omp-low.c

> > --- 912,917 ----
> > *************** debug_all_omp_regions (void)
> > *** 1219,1225 ****
> >    
> >    /* Create a new parallel region starting at STMT inside region PARENT.  */
> >    
> > ! struct omp_region *
> >    new_omp_region (basic_block bb, enum gimple_code type,
> >    		struct omp_region *parent)
> >    {
> > --- 1238,1244 ----
> >    
> >    /* Create a new parallel region starting at STMT inside region PARENT.  */
> >    
> > ! static struct omp_region *
> >    new_omp_region (basic_block bb, enum gimple_code type,
> >    		struct omp_region *parent)
> >    {
> Likewise.
again, because it is no longer an exported function...  only 
tree-cfg.c::make_edges needed it, and it no longer does.

Thanks.

Andrew