This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] omp-low.h


On Fri, Oct 11, 2013 at 5:31 AM, Andrew MacLeod <amacleod@redhat.com> wrote:
> Missed a bit in tree-flow.h..  I mistakenly assumed omp_region belonged
> there :-P
>
> Anyway by moving struct omp_region into omp_low.h, along with the prototypes
> from tree-flow.h, gimple.h and tree.h.  Everything works great with just a
> few files actually requiring omp-low.h.
>
> AS an extra bonus, omp-low.c was *exporting*  "struct omp_region
> *root_omp_region".   tree-cfg.c was checking it for non-null and calling
> free_omp_regions().   Well,  free_omp_regions works just fine will a NULL
> root_omp_region (basically does nothing and returns), so exporting it just
> for that one check seems nonsensical.  Its now static.
>
> Bootstraps (will really-all languages) on x86_64-unknown-linux-gnu with no
> new regressions.  also stage 1 cross builds on rs6000 and mips.  No more of
> that crap :-)
>
> OK?

Index: tree-flow.h
===================================================================
*** tree-flow.h (revision 203379)
--- tree-flow.h (working copy)
*************** along with GCC; see the file COPYING3.
*** 41,91 ****
                              OpenMP Region Tree
  ---------------------------------------------------------------------------*/

- /* Parallel region information.  Every parallel and workshare
-    directive is enclosed between two markers, the OMP_* directive
-    and a corresponding OMP_RETURN statement.  */
-
- struct omp_region

I can spot the end of a comment containing "OpenMP Region Tree"
that you didn't move - probably an oversight.

Otherwise ok.

Thanks,
Richard.

> Andrew
>
>
>
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]