This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Announcing <regex>?

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jonathan Wakely <jwakely dot gcc at gmail dot com>
Date: Wed, 02 Oct 2013 01:49:40 +0200
Subject: Re: Announcing <regex>?
Authentication-results: sourceware.org; auth=none
References: <5249C1FF dot 8050207 at oracle dot com> <CAPrifDmfZzgCH--xP=DD-XPSV5vFZdh7uh2frw=2SnR5XP2fMA at mail dot gmail dot com> <571E92A2-ADCC-4641-BAB3-C893943188E0 at oracle dot com> <CAPrifDmSjZYRpXvaoc52C6HY_48YyqwiJ3U7qoeEMXDrh2inRg at mail dot gmail dot com> <BE3189CF-DD65-427B-9836-BE4EC64E9715 at oracle dot com> <CAPrifD=aT+m6mWxjntMMpPRm7vhp2bmCbLU_8c6X8RufDqp9aA at mail dot gmail dot com>

On 10/02/2013 01:45 AM, Tim Shen wrote:

On Tue, Oct 1, 2013 at 6:41 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:

Ok, thus just say that transform_primary is unimplented. Please also add a comment inline in the code explaining the issue, but don't word it in term of <locale>, because <locale> is just what it is per C++11, and doesn't directly provide what we need in the public interface (if I understand the issue): just say that implementing the function appears to require libc support + a link to the message you sent a couple of weeks ago to the libstdc++-v3 mailing list.

Ok with the above changes.

Committed :)

Thanks. But then the function actually *is* implemented, saying 'notimplemented' is misleading. Please change the xml to something like'isn't correctly implemented', or more informally, 'needs work', up toyou, but please adjust it.


Thanks,
Paolo.

Follow-Ups:
- Re: Announcing <regex>?
  - From: Tim Shen

References:
- Re: Announcing <regex>?
  - From: Tim Shen
- Re: Announcing <regex>?
  - From: Paolo Carlini
- Re: Announcing <regex>?
  - From: Tim Shen
- Re: Announcing <regex>?
  - From: Paolo Carlini
- Re: Announcing <regex>?
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]