This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

On 09/18/2013 10:24 AM, Michael Matz wrote:

I'm irritated by the member name uglification (e.g. equiv_stack_ with
trailing underscore).  I know that's a certain style to mark private
members, but I think it's a bad style (like prefixing variable names with
their type), and before it sets a precedent in GCCs c++ coding style I'd
like this to be changed, like in the below.
We're already using the trailing underscore idiom for private objects moving into classes (see the pass class). Furthermore, we've used similar idioms in the past when moving objects from the global namespace into structures (the x_ prefixing you'll find in various structures).

You really should have chimed in before now.

I'd also like us to not use member privatization in our classes, but
that's not in the patch, but if we could agree on that it would be nice.
Member privatization is quite natural. What specifically do you not like about the practice?

Regstrapped on x86-64-linux, okay?
Obviously any ChangeLog, formatting and such can go in. However, the trailing underscore should stay given it's already established practice and has several nice benefits.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]