This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch to gcc/function] PR 58362
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Biener <rguenther at suse dot de>, Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Mon, 9 Sep 2013 07:49:53 -0500
- Subject: Re: [Patch to gcc/function] PR 58362
- Authentication-results: sourceware.org; auth=none
- References: <522CCF1B dot 8080007 at oracle dot com> <alpine dot LNX dot 2 dot 00 dot 1309090945470 dot 3869 at zhemvz dot fhfr dot qr> <522D8BBC dot 608 at oracle dot com> <alpine dot LNX dot 2 dot 00 dot 1309091132340 dot 3869 at zhemvz dot fhfr dot qr> <alpine dot LNX dot 2 dot 00 dot 1309091136460 dot 3869 at zhemvz dot fhfr dot qr> <20130909094311 dot GG1817 at tucnak dot redhat dot com> <alpine dot LNX dot 2 dot 00 dot 1309091144200 dot 3869 at zhemvz dot fhfr dot qr> <20130909094634 dot GH1817 at tucnak dot redhat dot com>
On Mon, Sep 9, 2013 at 4:46 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Mon, Sep 09, 2013 at 11:45:08AM +0200, Richard Biener wrote:
>> Well, in this case the patch should IMHO be a no-op.
>>
>> - warning (OPT_Wunused_parameter, "unused parameter %q+D", decl);
>> + warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wunused_parameter,
>> + "unused parameter %qD", decl);
>>
>> no? Unless I misunderstand what %q+D should do.
>
> The question is how exactly is %q+D defined, if it is
> warning_at (location_of (decl), OPT_Wunused_parameter, "unused parameter %qD", decl); in this case, or
> DECL_SOURCE_LOCATION (decl) instead.
The semantics of '%+D' was defined long before I got involved.
The way it was supposed to work is that we pick the location
of the decl being specified, instead of taking the current
location. When we figured that was insufficient, we introduced
%H to say: pick this location. For that reason, one can only have
on +D in a diagnostic message (I don't think we
-- Gaby