This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] track heap usage with -fmem-report


On Thu, Mar 7, 2013 at 1:59 PM, Richard Biener wrote:
> Index: gcc/toplev.c
> ===================================================================
> *** gcc/toplev.c        (revision 196517)
> --- gcc/toplev.c        (working copy)
> *************** along with GCC; see the file COPYING3.
> *** 74,79 ****
> --- 74,80 ----
>   #include "gimple.h"
>   #include "tree-ssa-alias.h"
>   #include "plugin.h"
> + #include "tree-pass.h"
>
>   #if defined(DBX_DEBUGGING_INFO) || defined(XCOFF_DEBUGGING_INFO)
>   #include "dbxout.h"

On the "don't need to know"-principle, can you please not do this, and
instead add the statistic dumper prototypes to statistics.h and
inclode that in toplev.c? Toplev doesn't have to know about passes.

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]