This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Performance patch for MIPS conditional move in expr.c
- From: Andrew Pinski <andrew dot pinski at caviumnetworks dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Steve Ellcey <sellcey at mips dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 7 Mar 2013 08:00:59 -0800
- Subject: Re: [patch] Performance patch for MIPS conditional move in expr.c
- References: <27d19005-b82d-4ecc-a81e-14208937ce0f@EXCHHUB01.MIPS.com> <CA+=Sn1k=eD2=Suc5VwoNkvToKEoyL_cuwmsh4iDjoGQCMa1P9w@mail.gmail.com> <1352921235.22862.6.camel@ubuntu-sellcey> <CA+=Sn1nn=PSNWVLEHLKwaqsyDPDYtNv4JudLFmCi4=E4+jTYXQ@mail.gmail.com> <1352929552.22862.13.camel@ubuntu-sellcey> <CA+=Sn1n6RTs4GpMF-h_Hj5XP3mDqSghHyfSYZZ_WmWzQxCFxUQ@mail.gmail.com> <CA+=Sn1nNxA+D1GQAbG84YWKmZc8eu=MbD91aiJHTmy2gT4S_Vw@mail.gmail.com> <20130307151206.GE12913@tucnak.redhat.com>
On Thu, Mar 7, 2013 at 7:12 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Nov 14, 2012 at 02:22:33PM -0800, Andrew Pinski wrote:
>> commit 8ca1e58de404bbe82b93bc240ef28c68c681243d
>> Author: Andrew Pinski <apinski@cavium.com>
>> Date: Thu Jul 26 18:09:34 2012 -0700
>>
>> 2012-07-26 Andrew Pinski <apinski@cavium.com>
>>
>> Bug #3261
>> * config/mips/mips.md (*mov<GPR:mode>_on_<MOVECC:mode>):
>> Remove mode check from comparisons.
>> (*mov<SCALARF:mode>_on_<MOVECC:mode>): Likewise.
>> (*mov<GPR:mode>_on_<GPR2:mode>_ne): New pattern to match
>> when (ne A 0) can be just A.
>
> Why aren't you also adding a *mov<SCALARF:mode>_on_<GPR2:mode>_ne
> insn?
Most likely because I only tested performance of this patch on
soft-float and I did not notice a reason for it yet.
Thanks,
Andrew Pinski