This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR56525
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 5 Mar 2013 12:30:15 +0100
- Subject: Re: [PATCH] Fix PR56525
- References: <alpine.LNX.2.00.1303051225220.3543@zhemvz.fhfr.qr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Mar 05, 2013 at 12:27:20PM +0100, Richard Biener wrote:
> This should fix PR56525, we reference ggc_freed loop structures
> from bb->loop_father when fix_loop_structure removes a loop
> and then calls flow_loops_find. Fixed by delaying the ggc_free
> part of loop removal until after that (I thought about other
> ways to fix the reference but they are way more intrusive).
>
> Bootstrap and regtest running on x86_64-unknown-linux-gnu.
>
> Richard.
>
> 2013-03-05 Richard Biener <rguenther@suse.de>
>
> PR middle-end/56525
> * loop-init.c (fix_loop_structure): Remove loops in two stages,
> not freeing them until the end.
Looks good to me (when reporting the bug, I actually thought about
defering the removal for the duration of the fixup too).
Jakub