This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin
On Thu, Nov 1, 2012 at 3:43 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Nov 01, 2012 at 03:38:13PM -0700, H.J. Lu wrote:
>> >> --- gcc/testsuite/gcc.target/i386/pr53249.c (revision 193061)
>> >> +++ gcc/testsuite/gcc.target/i386/pr53249.c (working copy)
>> >> @@ -1,4 +1,4 @@
>> >> -/* { dg-do compile { target { ! { ia32 } } } } */
>> >> +/* { dg-do compile { target { ! { ia32 || llp64 } } } } */
>> >> /* { dg-options "-O2 -mx32 -ftls-model=initial-exec -maddress-mode=short" } */
>> >>
>> >> struct gomp_task
>
> I don't think you should put -mx32 into dg-options, that's the same why
> -m64 or -m32 isn't desirable in dg-options. Those options should be
> given just from --target_board=unix/-mx32 or similar (or compiler's
> -default).
>
That is done on purpose since --target_board=unix/-mx32 is only useful
if x32 run-time is available. However, -mx32 compiling doesn't need
x32 run-time support. We can use maybe_x32 effective target to check
if -mx32 can compile.
--
H.J.