This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Cc: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, gcc-patches at gcc dot gnu dot org, mikestump at comcast dot net, iain at codesourcery dot com
- Date: Thu, 1 Nov 2012 14:41:26 -0700
- Subject: Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin
- References: <20120824140454.GA15563@bromo.med.uc.edu> <yddlih4wf7j.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <20121101134705.GA14886@bromo.med.uc.edu>
On Thu, Nov 1, 2012 at 6:47 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> On Fri, Aug 24, 2012 at 04:13:20PM +0200, Rainer Orth wrote:
>> Jack Howarth <howarth@bromo.med.uc.edu> writes:
>>
>> > Currently the new testcase for gcc.target/i386/pr53249.c is failing
>> > on darwin due to the absence of -mx32 support on that target. The following
>> > patch skips this testcase on darwin. Tested on x86_64-apple-darwin12...
>>
>> This also fails on Solaris/x86 (cf. PR testsuite/53365) and
>> i686-unknown-linux-gnu. I'd strongly prefer if HJ could devise a real
>> fix instead of just skipping the test on an explicit list of systems.
>>
>> Rainer
>
> Rainer,
> What about using...
>
> Index: gcc/testsuite/gcc.target/i386/pr53249.c
> ===================================================================
> --- gcc/testsuite/gcc.target/i386/pr53249.c (revision 193061)
> +++ gcc/testsuite/gcc.target/i386/pr53249.c (working copy)
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target { ! { ia32 } } } } */
> +/* { dg-do compile { target { ! { ia32 || llp64 } } } } */
> /* { dg-options "-O2 -mx32 -ftls-model=initial-exec -maddress-mode=short" } */
>
> struct gomp_task
>
> This converts the failure at -m64 into an unsupported testcase on x86_64-apple-darwin12.
This will disable test on Linux/x86-64.
--
H.J.