Re: [PATCH] Support official CLooG.org versions.

[Paolo Bonzini <bonzini at gnu dot org>]

On 11/12/2010 09:15 PM, Tobias Grosser wrote:
> I committed this patch and propose two more.
>
> * Use a CLooG header macro to check for the PPL Legacy backend
>
> Without that patch the PPL Legacy backend may be detected, even if only
> includes of CLooG ORG are in the path, but the cloog-ppl library is
> still in the system library directory.

Nice, thanks.

> * Addition of --enable-cloog-backend
>
> Implemented as you suggested. Now by default we use
> --enable-cloog-backend=ppl-legacy
> All other CLooG backends will fail configure. To use another backend
> this has to be defined explicitly by setting --enable-cloog-backend=isl
> or --enable-cloog-backend=ppl
>
> Could you have a look?

This is okay assuming you tested the patches with all three backends, 
and all had the correct outcome (if failing to compile GCC is one of 
those outcomes that's fine, but I'd like to know).

I understand you plan to drop ppl-legacy support code from the compiler, 
do you plan to support both isl and ppl in the future?

In any case --enable-cloog-backend is needed for the transition, so the 
patch is okay even if it will disappear before 4.6.  It is also okay, if 
you want, to commit it with isl default.

Paolo