Re: [PATCH] Support official CLooG.org versions.

[Paolo Bonzini <bonzini at gnu dot org>]

On 11/12/2010 05:09 AM, Jack Howarth wrote:
> > If the configure changes have the effect of deprecating something or
> > adjusting the required versions of something, there is a serious problem
> > and they should not have been approved: the documentation of prerequisites
> > in install.texi does not appear to have been changed and it still
> > specifies CLooG-PPL.  It is not acceptable to change the prerequisites
> > without including the documentation changes in the same commit.

That was not mentioned in the discussion of the patch.  In fact I 
suppose Cloog-PPL was simply not tested.  Andreas, did you try all 
possible configurations?

Also, if I understood correctly ISL and PPL are different ways to "do 
the same thing", and they should cause no differences in code 
generation.  I assumed this because the patch didn't require any 
testsuite adjustment.  Is this the case?  If so, we only need to 
document the new possible choice of Cloog libraries.

If not, however, as Joseph said we need: 1) documentation of the new 
prerequisites; 2) a --enable-cloog-ppl option to enable Cloog-PPL tests 
_and_ disable Cloog-ISL at the same time.  In this case, I suggest 
reverting the patch on trunk.

Paolo