This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping^2: RFA (build): Avoid circular dependency

On 11/12/2010 04:02 PM, Joern Rennecke wrote:
Quoting Paolo Bonzini <bonzini@gnu.org>:

On 11/12/2010 03:13 PM, Joern Rennecke wrote:
...
Are you still planning to do the review in the near future? 

Yes. Your patch has the disadvantage that a normal "make" will not
do the check anymore, because you removed the dependency from all to
s-tm-texi (which previously went all -> info -> gccint.info ->
tm.texi -> s-tm-texi).

We still have a gccint.info -> new-tm.texi -> s-tm-texi link.

Ok, I missed the last hunk. That is unfortunately wrong because you would force people who compile a release tarball to run makeinfo (because new-tm.texi) is not shipped.

I think your patch can be okay if you leave TEXI_GCCINT_FILES aside, and put an additional dependency

@MAINT@ all: new-tm.texi

Paolo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]