This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Graphite middle-end parts review
On Wed, 13 Aug 2008, Sebastian Pop wrote:
> On Wed, Aug 13, 2008 at 4:07 PM, Richard Guenther <rguenther@suse.de> wrote:
> >> No, Jan did the right thing here. I also think that we should have
> >> more systematic functions that take care of everything: creating the
> >> variable, etc.
> >
> > Right. Whoever creates the variable should add it. In this
> > place you either have created iv without using it in some cases
> > or my suggestion is correct. So - I don't agree with you.
>
> Okay, then why isn't add_referenced_var part of create_tmp_var? I
> don't like the separation of these two functions, but here is what I
> committed to the graphite branch.
That's an interesting question, and the answer is that we compute the
"referenced vars" set only before going into SSA and at least the
gimplifier also uses this function (it's after all "in" the gimplifier).
But we could definitely use a new wrapper function that does both.
Richard.