This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Graphite middle-end parts review
On Wed, 13 Aug 2008, Sebastian Pop wrote:
> Hi,
>
> Attached patch fixes most of the changes asked, except the factoring
> of update_dominators_in_loop code and the following two parts:
>
> On Thu, Aug 7, 2008 at 7:13 AM, Richard Guenther <rguenther@suse.de> wrote:
> > + /* Construct IV code in loop. */
> > + initial_value = force_gimple_operand (initial_value, &stmts, true, iv);
> > + if (stmts)
> > + {
> > + gsi_insert_seq_on_edge (loop_preheader_edge (loop), stmts);
> > + gsi_commit_edge_inserts ();
> > + }
> > +
> > + add_referenced_var (iv);
> >
> > The caller should have done this.
>
> No, Jan did the right thing here. I also think that we should have
> more systematic functions that take care of everything: creating the
> variable, etc.
Right. Whoever creates the variable should add it. In this
place you either have created iv without using it in some cases
or my suggestion is correct. So - I don't agree with you.
> > Index: gcc/passes.c
> > ===================================================================
> > --- gcc/passes.c (.../trunk) (revision 138275)
> > +++ gcc/passes.c (.../branches/graphite) (revision 138569)
> > @@ -661,6 +661,7 @@ init_optimization_passes (void)
> > NEXT_PASS (pass_check_data_deps);
> > NEXT_PASS (pass_loop_distribution);
> > NEXT_PASS (pass_linear_transform);
> > + NEXT_PASS (pass_graphite_transforms);
> >
> > So we still have loop-distribution and interchange before graphite?
>
> Yes for the moment this is not changed. It will change in the future.
Ok.
Richard.