This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR/28218, thinko in tree-ssa-math-opts.c
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- Date: Wed, 5 Jul 2006 00:26:11 +0200
- Subject: Re: [PATCH] PR/28218, thinko in tree-ssa-math-opts.c
- References: <44AA9FDF.4030808@lu.unisi.ch>
On Tuesday 04 July 2006 19:05, Paolo Bonzini wrote:
> I don't know where I got the idea that you can do
>
> calculate_dominance_info (CDI_DOMINATORS | CDI_POST_DOMINATORS);
>
> instead of
>
> calculate_dominance_info (CDI_DOMINATORS);
> calculate_dominance_info (CDI_POST_DOMINATORS);
It doesn't matter where you got that idea. GCC should punish you
for trying it.
Gr.
Steven
Index: dominance.c
===================================================================
--- dominance.c (revision 115112)
+++ dominance.c (working copy)
@@ -614,6 +614,8 @@ calculate_dominance_info (enum cdi_direc
struct dom_info di;
basic_block b;
+ gcc_assert (dir == CDI_DOMINATORS || dir == CDI_POST_DOMINATORS);
+
if (dom_computed[dir] == DOM_OK)
return;