This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix compiler build on non-Unix98 systems
- From: Geoffrey Keating <geoffk at geoffk dot org>
- To: Eric Botcazou <ebotcazou at libertysurf dot fr>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: 28 Oct 2004 16:38:15 -0700
- Subject: Re: Fix compiler build on non-Unix98 systems
- References: <200409290851.22163.ebotcazou@libertysurf.fr> <200410280834.58693.ebotcazou@libertysurf.fr>
Eric Botcazou <ebotcazou@libertysurf.fr> writes:
> > Your patch for PR 13684 added a non guarded use of PTHREAD_MUTEX_RECURSIVE
> > to gthr-posix.c, which makes it impossible to build the compiler on generic
> > non-Unix98 systems (e.g. Solaris 2.5.1 and 2.6). May I install the
> > attached patch to let the compiler build?
> >
> > 2004-09-29 Eric Botcazou <ebotcazou@libertysurf.fr>
> >
> > * gthr-posix.h (__gthread_recursive_mutex_init_function): Guard
> > with #ifdef PTHREAD_MUTEX_RECURSIVE/#endif pairs.
>
> Could a maintainer review this patch, please? Bootstrap has been broken for
> more than two months on these platforms. Thanks in advance.
>
> http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02924.html
This is OK.
I'm a bit concerned that SUS doesn't say that PTHREAD_MUTEX_RECURSIVE
has to be a preprocessor macro (it might be an enum). If there's a
system with that property, we'll need to back this patch out and go
for an autoconf test.