This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: enable Ada test suite
> I don't know if this is Andreas's problem, but this shell construct is
> unportable. You must write
It was not.
The issue was actually pretty trivial: he hadn't done a make gnatlib_and_tools
because of gcc crashes.
Obviousely if gnatlib_and_tools cannot build, there is no point in doing
a check.
> I see extensive use of this construct in run_all.sh. That's the only
> thing I see that I am certain cannot be used, but there are other
> things I'm dubious about, such as printf, mkdir -p, and cp -pr. I
> also see a large number of quoting errors. You should have a shell
> portability expert (Alexandre Oliva for instance) go over the script.
Reviews and contributions welcome.
Arno