This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: enable Ada test suite


Arnaud Charlet <charlet@ACT-Europe.FR> writes:

> I'd suggest replacing the calls to gnatchop by e.g.:
>
> for i in $dir/support/{*.ada,*.a}; do
>    gnatchop $i >> $dir/acats.log 2>&1
> done

I don't know if this is Andreas's problem, but this shell construct is
unportable.  You must write

  for i in $dir/support/*.ada $dir/support/*.a

I see extensive use of this construct in run_all.sh.  That's the only
thing I see that I am certain cannot be used, but there are other
things I'm dubious about, such as printf, mkdir -p, and cp -pr.  I
also see a large number of quoting errors.  You should have a shell
portability expert (Alexandre Oliva for instance) go over the script.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]