This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed cygwin/mingw dllimport patch for PRs 5287. 7910,11021
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Christopher Faylor <cgf at redhat dot com>
- Date: 10 Jun 2003 00:02:23 -0700
- Subject: Re: Unreviewed cygwin/mingw dllimport patch for PRs 5287. 7910,11021
- References: <20030608205717.43027.qmail@web21404.mail.yahoo.com>
On Sun, 2003-06-08 at 13:57, Danny Smith wrote:
> This patch:
>
> http://gcc.gnu.org/ml/gcc-patches/2003-05/msg02391.html
>
> and updated documentation:
>
> http://gcc.gnu.org/ml/gcc-patches/2003-05/msg02515.html
>
> fix several open mingw/cygwin PRS (C++/5287,C++/7910,C++/11021)
> on trunk, and adds testcases.
>
> Could someone please review?
This patch looks good to me, and I would very much like to have those
regressions closed.
Chris Faylor knows this code better than I, but if he does not have any
objections within a week, please check in your change.
! else if (TREE_CODE (TREE_TYPE (decl)) == METHOD_TYPE
! && DECL_VIRTUAL_P (decl))
! {
! return 0;
! }
That should have no braces; the GNU coding standards say a single
statement needn't be enclosed in braces.
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com