This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [3.4] DESTDIR support completed


Hello, Christian,

Thank you very much for pursuing this goal.  destdir4.diff is ok, but
I'm not entirely comfortable with this change:

On Jan  3, 2003, Christian Cornelssen <ccorn@cs.tu-berlin.de> wrote:

> Index: libstdc++-v3/ChangeLog

> +	* include/Makefile.am (install-data-local): [...]
> +	Use ${c_base_builddir} and ${std_builddir}
> +	as destination subdirectories to achieve consistency with
> +	preceding mkinstalldirs commands.  No effect because both
> +	variables contain "." only.

I suppose the goal in the Makefile rules is to make it clear that the
contents of these directories are not meant to be installed in
subdirectories, even if they were kept in subdirectories in the build
tree.  But then, it may just be a historical left-over from a day in
which they were kept in separate directories in the build tree.

libstdc++ folks, can you please comment on this?

Regardless, I think we may as well go ahead and install the change,
even if we have to revert these two lines afterwards.  Andreas, I'll
take your kind offer, if you haven't changed your mind :-) Thank you
both very much.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]