Re: [RFA:] libstdc++-v3 patches to bootstrap on gnulibc1 andglibc 2.0

[Benjamin Kosnik <bkoz at redhat dot com>]

No, please don't install as is.

Please enclose a unified ChangeLog, in the canonical GNU style as part of
you patch.

       * config/os/gnu-linux/bits/os_defines.h: Include <sys/types.h>.
        If not glibc 2.1 or higher, include <gnu/types.h> and define
        __off64_t as __loff_t.

Please don't include sys/types.h here, use features.h, which should
work with older glibc's as well. If older glibc needs this include,
then macro-guard it and include only in that case. Please use
new-style C++ comments.

        * libio.h [__P]: Move __THROW and __PMT into their own ifndef:s.
this part is fine.

        (__underflow, __overflow): Remove __THROW qualifier in declaration.
this part is confused. The comment above this change says:

! /* The absence of __THROW specifiers on __underflow and __overflow is
!    because those are declared in system headers on some systems without
!    any throw-specifier.  Those functions are not called from C++ within
!    libio anyway, so a throw specifier is redundant.  */

This isn't for 'some systems' this is for an old glibc. Can you be
more specific? What other system headers are you talking about? It
might make sense to just change the defines for __THROW for this
particular case, and not modify the signatures by removing the __THROW
macro.

We're trying to keep sync with net glibc/libio now. Please keep that in mind.



-benjamin