Re: target/6569: sparc-sun-solaris2.7 C testsuite regression incompile/20011119-2.c

[Mark Mitchell <mark at codesourcery dot com>]

--On Tuesday, May 07, 2002 09:32:50 PM +0200 Franz Sirl 
<Franz.Sirl-kernel@lauterbach.com> wrote:

> OK, here is a much better patch, instead of trying to figure out the
> right flags to test, I created a second list WEAK_EMITTED_DECLS and add
> all emitted weaks in globalize_decl() to it. Then in weak_finish() it's
> very easy to check for it.

Ack, our patches are fighting.

> Besides being easier to grok, it's also faster, cause we avoid to walk
> the WEAK_DECLS list on every declare_weak() call.

Yours will now be quadratic at weak_finish time.  We really ought to be
using hash tables for these things, but for now we can get by.

I'm not sure whether your patch or mine is better, but I think I prefer
mind on the grounds that it eliminates the references to the wrong DECLs
sooner.  DECLs take up lots of space, and we want to return them to the
collector.

Thoughts?

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com