Re: [patch, fortran] Asynchronous I/O, take 3

[Jerry DeLisle <jvdelisle at charter dot net>]

On 07/15/2018 07:21 AM, Rainer Orth wrote:
> Hi Thomas,
>
> > > I am currently testing the patch at
> > > https://gcc.gnu.org/ml/fortran/2018-07/msg00008.html
> > >
> > > so far, so good!
> >
> > > IMO the tests should go to gfortran.dg (they pass my tests).
> >
> > I put the asycn_io_*.f90 tests into libgomp.fortran because,
> > under Linux, gfortran.dg does not link in pthreads, so the
> > tests would not be executed in parallel, and some of them
> > would fail.
> >
> > So, here is the final version. I would really like to get this
> > into trunk, and out of the way, so Nicolas and I can focus on
> > other things.
>
> I've now regtested the patch on i386-pc-solaris2.11 and
> sparc-sun-solaris2.11: no regressions and the new tests all PASS.
>
> However, I still don't understand why you insist on the hack with
> putting the async_io_*.f90 tests into the libgomp testsuite.  Why not
> just make the pthread requirement explicit with
>
> { dg-require-effective-target pthread }
> { dg-additional-options "-pthread" }
>
> and put them in gfortran.dg where they belong?
>
> 	Rainer

Rainer, your point well understood. However, I would like to get the 
patch in and out to the world to get exercised by users so we can catch 
anything we miss.  We can work on the gfortran.dg incantations as a 
follow-on effort. (maybe a separate PR for it)

Jerry