This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, Fortran, cleanup] PR 78798: some int-valued functions should be bool
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: Janne Blomqvist <blomqvist dot janne at gmail dot com>, gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 15 Dec 2016 12:41:07 -0800
- Subject: Re: [Patch, Fortran, cleanup] PR 78798: some int-valued functions should be bool
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qiV=6F1SxPp=HP1H1r2j21wWFHxp+himusLUMY7ytTVUw@mail.gmail.com> <CAO9iq9F1Cw0xO3KvSiV6BPDS1NMYDRMd7YwZOqyJL=CDeUrh3w@mail.gmail.com> <CAKwh3qgpwi8TvTN=dnq+nES_1pqodHLgbf1dHn+BAeum3gxmYg@mail.gmail.com> <CAKwh3qiRWpRTsWGweMrMECKbjYQooHBcOewa+y7xBUahsG3Yqg@mail.gmail.com>
- Reply-to: kargl at uw dot edu
On Thu, Dec 15, 2016 at 08:38:47PM +0100, Janus Weil wrote:
> 2016-12-13 19:55 GMT+01:00 Janus Weil <janus@gcc.gnu.org>:
> > 2016-12-13 19:19 GMT+01:00 Janne Blomqvist <blomqvist.janne@gmail.com>:
> >> On Tue, Dec 13, 2016 at 8:13 PM, Janus Weil <janus@gcc.gnu.org> wrote:
> >>> Hi all,
> >>>
> >>> here is a straightforward cleanup patch that makes a few functions
> >>> return a bool instead of an int. Regtests cleanly on x86_64-linux-gnu.
> >>> Ok for trunk?
> >>
> >> Ok, thanks.
> >
> > Thanks, Janne. Committed as r243621.
>
>
> I realized that also lots of functions in interface.c could/should be
> converted from int to bool. Attached is a patch which does that.
>
> It's not small, but mostly mechanical, and regtests cleanly on
> x86_64-linux-gnu. Ok for trunk?
>
A quick scan of the patch did not reveal anything
that jumped out as wrong. OK to commit.
--
steve