Re: [Patch, Fortran, cleanup] PR 78798: some int-valued functions should be bool

[Janus Weil <janus at gcc dot gnu dot org>]

2016-12-13 19:55 GMT+01:00 Janus Weil <janus@gcc.gnu.org>:
> 2016-12-13 19:19 GMT+01:00 Janne Blomqvist <blomqvist.janne@gmail.com>:
>> On Tue, Dec 13, 2016 at 8:13 PM, Janus Weil <janus@gcc.gnu.org> wrote:
>>> Hi all,
>>>
>>> here is a straightforward cleanup patch that makes a few functions
>>> return a bool instead of an int. Regtests cleanly on x86_64-linux-gnu.
>>> Ok for trunk?
>>
>> Ok, thanks.
>
> Thanks, Janne. Committed as r243621.


I realized that also lots of functions in interface.c could/should be
converted from int to bool. Attached is a patch which does that.

It's not small, but mostly mechanical, and regtests cleanly on
x86_64-linux-gnu. Ok for trunk?

Cheers,
Janus


2016-12-15  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/78798
    * gfortran.h (gfc_compare_derived_types,gfc_compare_types,
    gfc_compare_interfaces,gfc_has_vector_subscript): Return bool instead
    of int.
    * interface.c (compare_components): Ditto.
    (gfc_compare_union_types): Rename to compare_union_types, declare as
    static, return bool.
    (gfc_compare_derived_types): Return bool instead of int.
    (gfc_compare_types): Ditto.
    (compare_type): Ditto.
    (compare_rank): Ditto.
    (compare_type_rank): Ditto.
    (compare_type_rank_if): Ditto.
    (count_types_test): Ditto.
    (generic_correspondence): Ditto.
    (gfc_compare_interfaces): Ditto.
    (check_interface0): Ditto.
    (check_interface1): Ditto.
    (compare_allocatable): Ditto.
    (compare_parameter): Ditto.
    (gfc_has_vector_subscript): Ditto.
    (compare_actual_formal): Ditto.

Attachment: pr78798_part2.diff
Description: Text document