Re: [PATCH, Fortran, pr78672, ctp1, v1] Gfortran test suite failures with a sanitized compiler

[Andre Vehreschild <vehre at gmx dot de>]

Hi Steve,

Oh I was totally oblivious that this is C++. It comes naturally to me. So I did not get what the problem could be. What to do about it? Are there defines that hide this?

- Andre

Am 9. Dezember 2016 17:29:16 MEZ, schrieb Steve Kargl <sgk@troutmask.apl.washington.edu>:
>On Fri, Dec 09, 2016 at 11:23:02AM +0100, Andre Vehreschild wrote:
>> Hi Jerry,
>> 
>> > For those of us who don't always get it, can you explain this line:
>> > 
>> > -  /* There's no ABS for HOST_WIDE_INT, so here we go. It also
>takes care
>> > -     of the asymmetric range of the integer type.  */
>> > -  n = (unsigned HOST_WIDE_INT) (m < 0 ? -m : m);
>> > +  n = wi::abs (wrhs).to_shwi ();                <======
>> 
>> I am not sure, what you expect here. Do you desire me to add a
>comment to the
>> code or tell my intentions why I think the new line is idem-potent to
>the old
>> one?
>> 
>
>I think the issue here is that some who contribute to gfortran have
>ZERO knowledge of C++.  The line you remove is quite clear.  The new
>line is quite opaque.  As more C++ creeps into the Fortran FE, it is
>likely that some may stop contributing. 

-- 
Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen
Tel.: +49 241 929 10 18 * vehre@gmx.de