Re: [PATCH, Fortran, pr78672, ctp1, v1] Gfortran test suite failures with a sanitized compiler

[Steve Kargl <sgk at troutmask dot apl dot washington dot edu>]

On Fri, Dec 09, 2016 at 11:23:02AM +0100, Andre Vehreschild wrote:
> Hi Jerry,
> 
> > For those of us who don't always get it, can you explain this line:
> > 
> > -  /* There's no ABS for HOST_WIDE_INT, so here we go. It also takes care
> > -     of the asymmetric range of the integer type.  */
> > -  n = (unsigned HOST_WIDE_INT) (m < 0 ? -m : m);
> > +  n = wi::abs (wrhs).to_shwi ();                <======
> 
> I am not sure, what you expect here. Do you desire me to add a comment to the
> code or tell my intentions why I think the new line is idem-potent to the old
> one?
> 

I think the issue here is that some who contribute to gfortran have
ZERO knowledge of C++.  The line you remove is quite clear.  The new
line is quite opaque.  As more C++ creeps into the Fortran FE, it is
likely that some may stop contributing. 

-- 
Steve