]> gcc.gnu.org Git - gcc.git/commitdiff
libgomp: Fix up build on mingw [PR107641]
authorJakub Jelinek <jakub@redhat.com>
Sat, 12 Nov 2022 08:47:50 +0000 (09:47 +0100)
committerJakub Jelinek <jakub@redhat.com>
Sat, 12 Nov 2022 08:50:04 +0000 (09:50 +0100)
Pointers should be first casted to intptr_t/uintptr_t before casting
them to another integral type to avoid warnings.
Furthermore, the function has code like
  else if (upper <= UINT_MAX)
    something;
  else
    something_else;
so it seems using unsigned type for upper where upper <= UINT_MAX is always
true is not intended.

2022-11-12  Jakub Jelinek  <jakub@redhat.com>

PR libgomp/107641
* env.c (parse_unsigned_long): Cast params[2] to uintptr_t rather than
unsigned long.  Change type of upper from unsigned to unsigned long.

libgomp/env.c

index 0249966e8a6fbe09ce1631eba7c2ecc1e8fb210b..279937bb36cbf50fc3b9e7c6f088f7d940d3065f 100644 (file)
@@ -283,7 +283,7 @@ parse_unsigned_long_1 (const char *env, const char *val, unsigned long *pvalue,
 static bool
 parse_unsigned_long (const char *env, const char *val, void *const params[])
 {
-  unsigned upper = (unsigned long) params[2];
+  unsigned long upper = (uintptr_t) params[2];
   unsigned long pvalue = 0;
   bool ret = parse_unsigned_long_1 (env, val, &pvalue, (bool) params[1]);
   if (!ret)
This page took 0.063283 seconds and 5 git commands to generate.