This is the mail archive of the
mailing list for the Java project.
Re: [RFC/RFT] Patch (java): Switch to new verifier
- From: Per Bothner <per at bothner dot com>
- To: Ranjit Mathew <rmathew at gmail dot com>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 27 Feb 2005 11:52:11 -0800
- Subject: Re: [RFC/RFT] Patch (java): Switch to new verifier
- References: <4222166D.firstname.lastname@example.org>
Ranjit Mathew wrote:
> OK for mainline?
I'll let Tom make this call: If he thinks we're ready to switch,
then great - let's do so.
> FWIW, the new verifier does seem a bit slower than the old one,
Some performance tuning might be worthwhile. I see some obvious
micro-optimizations, but I suspect they won't make much difference.
Still, wouldn't urt:
get_short, get_short, get_int should have their get_byte calls inlines,
and the test for "premature end of bytecode" only done once.
Various places get_byte etc are called and the result ignored.
They could be replaced by skip_bytes (N). E.g. in op_multianewarray
replace 'get_short(); get_byte();' by 'skip_bytes (3);'.