Re: Re: Patch: add extensions directory contents to VMClassLoader class path.

[Ranjit Mathew <rmathew at gmail dot com>]

On Fri, 18 Jun 2004 12:57:03 +0100, Andrew Haley <aph@redhat.com> wrote:
> 
> Ranjit Mathew writes:
>  > Andrew Haley wrote:
>  > > Ranjit Mathew writes:
>  > [...]
>  > >  > we're installing the SEGV handler only after the VMClassLoader
>  > >  > has initialised. Hence the SEGV was not caught via the
>  > >  > normal exception handling mechanism.
>  > >
>  > > Ah, okay.  Not a problem then.
>  > 
>  > Do I take this as an "OK" for the "dir.exists()" patch?
> 
> It looks to me as though that patch qualifies for the "fixes something
> broken, obviously correct" get-out clause.

I was perhaps being a bit too careful... :-/


> [P.S.  If you just throw an "if" around a block of code, it's much
> easier to understand a patch made with "diff -w".]

That's a nifty thing to know - thanks!


[...]
>  > Is this OK for mainline?
> 
> Yes, OK.  This is a more risky patch, but at this stage in the
> development cycle we can give it a go.
> 
>  > In any case, I think the "dir.exists()" patch should still
>  > be applied - there's no reason to wait for a NullPointerException
>  > to be thrown if it can be avoided easily.
> 
> I agree.

Thanks - I've applied both the patches to mainline.

Ranjit.