This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Your ia64 patch may have broken libjava


>>>>> On Wed, 7 May 2003 19:04:54 +0100, Andrew Haley <aph@redhat.com> said:

  Andrew> I'm very interested in libunwind for IA-64 because it should
  Andrew> give me a clean way to get a stack trace.  Stack traces
  Andrew> don't work on IA-64 gcj at the moment, and that causes a ton
  Andrew> of problems.

Glad to hear that.  At the moment, I'm not aware of libunwind RPMs but
if someone makes them available, I'd be happy to add a link to them on
the libunwind web site (http://www.hpl.hp.com/research/linux/libunwind/).
Also, you might want to check with Jeff Johnston at Red Hat.  He is
working on integrating libunwind into gdb, so he might already have some
RPMs.

On the _Unwind_FindEnclosingFunction() issue: I found that
config/ia64/libunwind-ia64.c simply defines it as a dummy function
returning NULL.  The patch below does the same for unwind-libunwind.c.
However, I do wonder whether this is really the right solution.  Isn't
this used for some sort of security check?  Is it really OK to always
return NULL in this function?

In the meantime, would someone be so kind to check in the attached
patch?

Thanks,

	--david

2003-03-31  David Mosberger <davidm@hpl.hp.com>

	* unwind-libunwind.c (_Unwind_FindEnclosingFunction): New
          function.

Index: gcc/unwind-libunwind.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/unwind-libunwind.c,v
retrieving revision 1.5
diff -u -r1.5 unwind-libunwind.c
--- gcc/unwind-libunwind.c	3 Apr 2003 02:06:55 -0000	1.5
+++ gcc/unwind-libunwind.c	7 May 2003 18:20:15 -0000
@@ -161,6 +161,12 @@
   return (_Unwind_Ptr) pi.start_ip;
 }
 
+void *
+_Unwind_FindEnclosingFunction (void *pc)
+{
+  return NULL;
+}
+
 #include "unwind.inc"
 
 #endif /* !__USING_SJLJ_EXCEPTIONS__ */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]