This is the mail archive of the
mailing list for the GCC project.
Re: Iterative dataflow function
- To: dan at cgsoftware dot com, gcc at gcc dot gnu dot org
- Subject: Re: Iterative dataflow function
- From: Jan Hubicka <jh at suse dot cz>
- Date: Wed, 1 Aug 2001 19:51:19 +0200
> So i got tired of seeing 8 million different implementations of
> worklist algorithms, and made a function that performs iterative
> bitvector dataflow for us.
> Is something like this useful enough? It seriously cuts down on the
> amount of code in most of our dataflow algorithms (LCM, etc).
Yes, Yes, YES. (IMO:)
Avoiding any code duplication in gcc is wonderfull IMO!
We should be curefull to not introduce so much of it.
In this case the duplicated hunk is small, but yet usefull and may be
optimized if dataflow turns out to be performance bottleneck in future.
> I've already got it doing iteration in reverse completion order, using a
> fibheap based priority queue as the worklist (df_visit_next is, right
> now, O(n)).
Adding fibheaps themselves to the libiberty can be wonderfull addition too.
I have some other palces, where fibheap is best fitting datastructure, but
my plan was to avoid using it, just as I am lazy to implement it and sorting
woud work just "well enought".