This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gcc::context creation
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Nathan Sidwell <nathan at acm dot org>
- Cc: Richard Biener <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 5 Jun 2017 14:50:06 +0200
- Subject: Re: [PATCH] gcc::context creation
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 583E14E34C
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 583E14E34C
- References: <7f7f64a5-f820-a19a-d4ea-77b05f746499@acm.org> <98b0273e-9390-18ce-c041-31f843b8b1f8@acm.org> <20170524105728.GZ8499@tucnak> <9f46c2f8-2bee-ef41-3c98-acf7d0012e54@acm.org> <20170524115731.GE8499@tucnak> <a778a628-0c1b-7d9e-d510-b19186d624f5@acm.org> <20170605094603.GB2154@tucnak> <c3afbf4a-c4f5-a89d-d326-3cdb0e25715b@acm.org> <20170605114736.GE2154@tucnak> <94603974-f4bc-6e9e-c282-604991c271b6@acm.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Jun 05, 2017 at 08:46:21AM -0400, Nathan Sidwell wrote:
> On 06/05/2017 07:47 AM, Jakub Jelinek wrote:
>
> > Whether there is a blank between function and its function comment
> > is something we aren't consistent in, but it seems that in dumpfile.c
> > there is a blank line, so I'm adjusting.
>
> Ok (I only know the blank line rule because someone nitted one of my
> patches)
>
>
> > +#define FIRST_AUTO_NUMBERED_DUMP 1
> > +#define FIRST_ME_AUTO_NUMBERED_DUMP 3
>
> When you commit, could you set this to 4 (at least). Right now you have no
> headroom for C++ FE changes. And I have a branch with a new lang dump :)
It was the intent that there is no unnecessary gap, the difference
between those two should be simply the maximum any FE registers.
So, on your branch you'd bump it to 4 and on trunk when merging your branch.
Jakub