This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gcc::context creation

From: Nathan Sidwell <nathan at acm dot org>
To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 5 Jun 2017 08:46:21 -0400
Subject: Re: [PATCH] gcc::context creation
Authentication-results: sourceware.org; auth=none
References: <7f7f64a5-f820-a19a-d4ea-77b05f746499@acm.org> <98b0273e-9390-18ce-c041-31f843b8b1f8@acm.org> <20170524105728.GZ8499@tucnak> <9f46c2f8-2bee-ef41-3c98-acf7d0012e54@acm.org> <20170524115731.GE8499@tucnak> <a778a628-0c1b-7d9e-d510-b19186d624f5@acm.org> <20170605094603.GB2154@tucnak> <c3afbf4a-c4f5-a89d-d326-3cdb0e25715b@acm.org> <20170605114736.GE2154@tucnak>

On 06/05/2017 07:47 AM, Jakub Jelinek wrote:

Whether there is a blank between function and its function comment
is something we aren't consistent in, but it seems that in dumpfile.c
there is a blank line, so I'm adjusting.

Ok (I only know the blank line rule because someone nitted one of mypatches)

+#define FIRST_AUTO_NUMBERED_DUMP 1
+#define FIRST_ME_AUTO_NUMBERED_DUMP 3

When you commit, could you set this to 4 (at least). Right now you haveno headroom for C++ FE changes. And I have a branch with a new lang dump :)


nathan
--
Nathan Sidwell

Follow-Ups:
- Re: [PATCH] gcc::context creation
  - From: Jakub Jelinek

References:
- Re: [PATCH] gcc::context creation
  - From: Jakub Jelinek
- Re: [PATCH] gcc::context creation
  - From: Nathan Sidwell
- Re: [PATCH] gcc::context creation
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]