This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: MN10300: Replace cc0 with CC_REG
- From: Richard Henderson <rth at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: law at redhat dot com, aoliva at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 13 Oct 2010 08:57:08 -0700
- Subject: Re: RFA: MN10300: Replace cc0 with CC_REG
- References: <m3ocay5deo.fsf@redhat.com>
On 10/13/2010 08:18 AM, Nick Clifton wrote:
> You are right, they are not needed ... yet. They are needed in a patch
> to come, but I have removed them for now.
Fine.
>> Are you planning to eliminate redundant compares via peepholes?
>
> Eventually yes, but not until a few more patches have gone in.
Sure.
> +(define_insn "float_conditional_branch"
> [(set (pc)
> + (if_then_else (match_operator 0 "comparison_operator" [(reg:CC_FLOAT CC_REG) (const_int 0)])
> + (label_ref (match_operand 1 "" ""))
...
> + emit_jump_insn (gen_float_conditional_branch (gen_rtx_fmt_ee (GET_CODE (operands[3]),
> + CCmode,
> + gen_rtx_REG (CCmode, CC_REG),
> + const0_rtx),
> + operands[2]));
Looks like you've got the wrong mode there during creation.
Otherwise it looks ok.
r~