Bug 60794 - 25 libstdc++ tests are missing '{ dg-require-debug-mode "" }'
Summary: 25 libstdc++ tests are missing '{ dg-require-debug-mode "" }'
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 4.9.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-09 13:15 UTC by John Marino
Modified: 2015-03-18 13:08 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments
Patch to add debug-mode requirement to 25 libstdc++ tests (510 bytes, text/plain)
2014-04-09 13:15 UTC, John Marino
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino 2014-04-09 13:15:07 UTC
Created attachment 32573 [details]
Patch to add debug-mode requirement to 25 libstdc++ tests

Twenty-five (25) libstdc++ tests require the debug-mode option but this is not specified.  I've carried the attached patch for years, time to try to get it properly into the gcc testsuite base.

The tests are:
23_containers/deque/debug/assign4_neg.cc
23_containers/deque/debug/construct4_neg.cc
23_containers/deque/debug/insert4_neg.cc
23_containers/list/debug/assign4_neg.cc
23_containers/list/debug/construct4_neg.cc
23_containers/list/debug/insert4_neg.cc
23_containers/map/debug/construct4_neg.cc
23_containers/map/debug/insert4_neg.cc
23_containers/multimap/debug/construct4_neg.cc
23_containers/multimap/debug/insert4_neg.cc
23_containers/multiset/debug/construct4_neg.cc
23_containers/multiset/debug/insert4_neg.cc
23_containers/set/debug/construct4_neg.cc
23_containers/set/debug/insert4_neg.cc
23_containers/unordered_map/debug/construct4_neg.cc
23_containers/unordered_map/debug/insert4_neg.cc
23_containers/unordered_multimap/debug/construct4_neg.cc
23_containers/unordered_multimap/debug/insert4_neg.cc
23_containers/unordered_multiset/debug/construct4_neg.cc
23_containers/unordered_multiset/debug/insert4_neg.cc
23_containers/unordered_set/debug/construct4_neg.cc
23_containers/unordered_set/debug/insert4_neg.cc
23_containers/vector/debug/assign4_neg.cc
23_containers/vector/debug/construct4_neg.cc
23_containers/vector/debug/insert4_neg.cc
Comment 1 Jonathan Wakely 2014-04-09 15:32:52 UTC
Why do you think they require debug mode?

Those tests are supposed to run in normal mode, that's why they explicitly use <debug/vector> and __gnu_debug::vector (which is how to use the debug containers in normal mode)
Comment 2 John Marino 2014-04-09 16:16:45 UTC
Hmmm, only 3 of the 25 files use <debug/vector> and __gnu_debug::vector
  23_containers/vector/debug/assign4_neg.cc
  23_containers/vector/debug/construct4_neg.cc
  23_containers/vector/debug/insert4_neg.cc

That said, all 25 have some form of "#include <debug/X>" and __gnu_debug::X so likely you were only applying an example for one subset.

I honestly can't remember the exact failure that this solved at the time (gcc 4.6 timeframe).  I want to say the first file I fixed back then was deque/debug/assign4_neg.cc

It's possible that that I saw debug-mode used in the 1,2,3 versions and thought it was oversight with the 4 versions, but I would have only looked at it upon a failure.


All that said, if all 25 look right to you then I'll humbly accept it and a closed/invalid bug status.
Comment 3 John Marino 2015-03-18 13:08:55 UTC
report was invalid, closing.