Bug 57229 - 4.6/4.7/4.8 inconsistent check for PRE_MODIFY/POST_MODIFY in post_reload (reload_cse_move2add)
Summary: 4.6/4.7/4.8 inconsistent check for PRE_MODIFY/POST_MODIFY in post_reload (rel...
Status: RESOLVED DUPLICATE of bug 94516
Alias: None
Product: gcc
Classification: Unclassified
Component: rtl-optimization (show other bugs)
Version: 4.6.3
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-09 14:09 UTC by rwahl
Modified: 2024-10-31 04:54 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:

Attachments
Proposed fix. (269 bytes, patch)
2013-05-09 14:09 UTC, rwahl 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rwahl 2013-05-09 14:09:29 UTC 
Created attachment 30077 [details]
Proposed fix.

I have found an inconsistency in postreload.c: move2add_note_store(). While reload_combine_note_store() has been fixed to deal with PRE_MODIFY/POST_MODIFY in PR 47008 this change is missing for move2add_note_store(). This actually may lead to wrong code for the msp430 arch (which currently is not yet officially supported). But I think the code should be fixed anyway to avoid any surprise when some arch is triggering it. See the attached fix.

This is the URL of the mspgcc bug report: https://sourceforge.net/p/mspgcc/bugs/353/
Comment 1 Sam James 2024-10-31 04:44:43 UTC 
An RTL expert (not me) needs to figure out if this is still relevant.
Comment 2 Andrew Pinski 2024-10-31 04:54:04 UTC 
r10-7617-g70b55b25aa14b60f0e0f0193f7178bae756076ad definitely fixed this issue so closing as a dup of bug 94516.

"while
    move2add_note_store has some code to handle {PRE,POST}_{INC,DEC} without
    REG_INC note, it doesn't handle {PRE,POST}_MODIFY (that would be enough
    to fix this testcase)"

*** This bug has been marked as a duplicate of bug 94516 ***