Bug 52626 - make check fixinclude test FAILURES
Summary: make check fixinclude test FAILURES
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: other (show other bugs)
Version: 4.8.0
: P3 normal
Target Milestone: 4.8.0
Assignee: Rainer Orth
URL: http://gcc.gnu.org/ml/gcc-patches/201...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 20:28 UTC by Igor Zamyatin
Modified: 2012-03-22 16:26 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2012-03-21 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Zamyatin 2012-03-19 20:28:19 UTC
Issue appeared after revision 185392:

Author: ro <ro@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Mar 14 17:08:03 2012 +0000
 
    Remove obsolete Solaris 8 support


Snippet from make check report:
pthread.h /export/users/izamyati/trunk_for_check/fixincludes/tests/base/pthread.h differ: byte 2526, line 86
*** pthread.h	2012-03-20 00:03:27.660335543 +0400
--- /export/users/izamyati/trunk_for_check/fixincludes/tests/base/pthread.h	2012-03-16 13:25:18.787318293 +0400
***************
*** 83,91 ****
  #define PTHREAD_MUTEX_INITIALIZER	{{{0},0}, {{{0}}}, {0}}
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
! #define PTHREAD_COND_INITIALIZER	{{{0}, 0}, 0}	/* DEFAULTCV */
  #else
! #define PTHREAD_COND_INITIALIZER	{{{0}, 0}, {0}}	/* DEFAULTCV */
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
  #define	PTHREAD_MUTEX_INITIALIZER		/* = DEFAULTMUTEX */	\
--- 83,91 ----
  #define PTHREAD_MUTEX_INITIALIZER	{{{0},0}, {{{0}}}, {0}}
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
! #define PTHREAD_COND_INITIALIZER	{{{0}, 0, 0x4356}, 0}	/* DEFAULTCV */
  #else
! #define PTHREAD_COND_INITIALIZER	{{{0}, 0, 0x4356}, {0}}	/* DEFAULTCV */
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
  #define	PTHREAD_MUTEX_INITIALIZER		/* = DEFAULTMUTEX */	\

There were fixinclude test FAILURES
make: *** [check] Error 1
Comment 1 Rainer Orth 2012-03-21 16:33:00 UTC
My fault, patch submitted.

Sorry.
  Rainer
Comment 2 Rainer Orth 2012-03-22 16:07:53 UTC
Author: ro
Date: Thu Mar 22 16:07:47 2012
New Revision: 185699

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185699
Log:
Fix pthread.h failure (PR other/52626)

	PR other/52626
	* tests/base/pthread.h [SOLARIS_MUTEX_INIT_2_CHECK]
	(PTHREAD_COND_INITIALIZER): Adapt for solaris_cond_init removal.

Modified:
    trunk/fixincludes/ChangeLog
    trunk/fixincludes/tests/base/pthread.h
Comment 3 Rainer Orth 2012-03-22 16:26:35 UTC
Fixed for 4.8.0.