Bug 48436 - Regresion @171731: Missing #include "reload.h"
Summary: Regresion @171731: Missing #include "reload.h"
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: c (show other bugs)
Version: 4.7.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 15:54 UTC by Jan-Benedict Glaw
Modified: 2011-04-04 16:50 UTC (History)
3 users (show)

See Also:
Host:
Target: vax-linux
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments
Patch fixing the regression. (265 bytes, patch)
2011-04-04 15:54 UTC, Jan-Benedict Glaw
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Benedict Glaw 2011-04-04 15:54:07 UTC
Created attachment 23868 [details]
Patch fixing the regression.

Hi!

171731 introduces an access macro reg_equiv_mem(), which is now used in the VAX backend. However, the header file isn't included, so the VAX backend (tested for --target=vax-linux) now breaks:

[...]
gcc -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wmis
sing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Wold-style-definition -Wc++-compat -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber    \
                ../../gcc/gcc/config/vax/vax.c -o vax.o
../../gcc/gcc/config/vax/vax.c: In function ‘nonindexed_address_p’:
../../gcc/gcc/config/vax/vax.c:1680: warning: implicit declaration of function ‘reg_equiv_mem’
../../gcc/gcc/config/vax/vax.c:1681: warning: passing argument 1 of ‘indirectable_address_p’ makes pointer from integer without a cast

[...]

make[1]: Entering directory `/mnt/nfs-programming/toolchain/gcc-build/gcc'
gcc   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wmissin
g-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Wold-style-definition -Wc++-compat -fno-common 
 -DHAVE_CONFIG_H  -o cc1 c-lang.o c-family/stub-objc.o attribs.o c-errors.o c-decl.o c-typeck.o c-convert.o c-aux-info.o c-objc-common.o 
c-parser.o tree-mudflap.o c-family/c-common.o c-family/c-cppbuiltin.o c-family/c-dump.o c-family/c-format.o c-family/c-gimplify.o c-famil
y/c-lex.o c-family/c-omp.o c-family/c-opts.o c-family/c-pch.o c-family/c-ppoutput.o c-family/c-pragma.o c-family/c-pretty-print.o c-family/c-semantics.o c-family/c-ada-spec.o  \
          cc1-checksum.o main.o tree-browser.o libbackend.a ../libcpp/libcpp.a ../libdecnumber/libdecnumber.a ../libcpp/libcpp.a   ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a    -lmpc -lmpfr -lgmp -rdynamic -ldl  -L../zlib -lz
libbackend.a(vax.o): In function `nonindexed_address_p':
/mnt/nfs-programming/toolchain/gcc-build/gcc/../../gcc/gcc/config/vax/vax.c:1679: undefined reference to `reg_equiv_mem'
/mnt/nfs-programming/toolchain/gcc-build/gcc/../../gcc/gcc/config/vax/vax.c:1679: undefined reference to `reg_equiv_mem'
collect2: ld returned 1 exit status
make[1]: *** [cc1] Error 1
make[1]: Leaving directory `/mnt/nfs-programming/toolchain/gcc-build/gcc'
make: *** [all-gcc] Error 2


The attached patch fixes this regression by including the header file defining the used macro. (ChangeLog is in the patch file, needs the PR number.)
Comment 1 Jan-Benedict Glaw 2011-04-04 16:09:21 UTC
Oh, it was fixed some hours before. Thanks!
Comment 2 Jeffrey A. Law 2011-04-04 16:50:31 UTC
I checked in an equivalent patch.