Bug 47234 - ipa-split is executed before profile feedback is read
Summary: ipa-split is executed before profile feedback is read
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: tree-optimization (show other bugs)
Version: 4.6.0
: P3 normal
Target Milestone: ---
Assignee: Jan Hubicka
URL:
Keywords:
Depends on:
Blocks: mozillametabug
  Show dependency tree / graph
 
Reported: 2011-01-09 16:07 UTC by Jan Hubicka
Modified: 2011-01-10 14:37 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2011-01-09 16:07:49

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Hubicka 2011-01-09 16:07:18 UTC 
This happens since tree-profile SSA reorg. Obviously ipa-split it profile driven pass and should be done afterwards.  Working on patch.

This also makes it ipossible to profile w/o LTO and use it for LTO build
Comment 1 Jan Hubicka 2011-01-09 23:05:05 UTC 
Patch posted http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00509.html
Comment 2 Jan Hubicka 2011-01-10 14:33:08 UTC 
Author: hubicka
Date: Mon Jan 10 14:33:04 2011
New Revision: 168632

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168632
Log:

	PR tree-optimization/47234 
	* tree-pass.h (TODO_rebuild_cgraph_edges): New TODO.
	(pass_feedback_split_functions): Declare.
	* passes.c (init_optimization_passes): Add ipa-split as subpass of
	tree-profile.
	* ipa-split.c (gate_split_functions): Update comments; disable
	split-functions for profile_arc_flag and branch_probabilities.
	(gate_feedback_split_functions): New function.
	(execute_feedback_split_functions): New function.
	(pass_feedback_split_functions): New global var.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-split.c
    trunk/gcc/passes.c
    trunk/gcc/tree-pass.h
Comment 3 Jan Hubicka 2011-01-10 14:37:07 UTC 
Fixed.