Bug 46314 - frontends use ASM_GENERATE_INTERNAL_LABEL
Summary: frontends use ASM_GENERATE_INTERNAL_LABEL
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: middle-end (show other bugs)
Version: 4.6.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks: 44566 enable-werror-always
  Show dependency tree / graph
 
Reported: 2010-11-05 15:28 UTC by Jorn Wolfgang Rennecke
Modified: 2010-11-06 15:13 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jorn Wolfgang Rennecke 2010-11-05 15:28:53 UTC 
cp/method.c:  ASM_GENERATE_INTERNAL_LABEL (buf, "LTHUNK", thunk_labelno);
java/class.c:  ASM_GENERATE_INTERNAL_LABEL (buf, name, alias_labelno++);  
java/expr.c:  ASM_GENERATE_INTERNAL_LABEL(buf, "LJpc=", start_label_pc_this_method + pc);
java/expr.c:  ASM_GENERATE_INTERNAL_LABEL(buff, "LJv", l_number);

I currently get a warning building java for picochip because of this issue.

We should have a target hook so that we can wean the frontends off this macro.
Comment 1 Jorn Wolfgang Rennecke 2010-11-06 15:04:58 UTC 
Author: amylaar
Date: Sat Nov  6 15:04:52 2010
New Revision: 166404

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166404
Log:
	PR middle-end/46314
gcc:
	* target.def (generate_internal_label): New asm_out hook.
	* output.h (default_generate_internal_label): Declare.
	* varasm.c (default_generate_internal_label): Define.
gcc/cp:
	* method.c (make_alias_for_thunk):
	Use targetm.asm_out.generate_internal_label.
gcc/java:
	* class.c: Include target.h.
	(make_local_function_alias):
	Use targetm.asm_out.generate_internal_label.
	* expr.c (lookup_label, generate_name): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/method.c
    trunk/gcc/java/ChangeLog
    trunk/gcc/java/class.c
    trunk/gcc/java/expr.c
    trunk/gcc/output.h
    trunk/gcc/target.def
    trunk/gcc/varasm.c
Comment 2 Jorn Wolfgang Rennecke 2010-11-06 15:13:34 UTC 
Patch has been applied to trunk.