Bug 45227 - libcpp Makefile does not enable instrumentation
Summary: libcpp Makefile does not enable instrumentation
Status: RESOLVED WORKSFORME
Alias: None
Product: gcc
Classification: Unclassified
Component: preprocessor (show other bugs)
Version: 4.6.0
: P3 normal
Target Milestone: 12.0
Assignee: Not yet assigned to anyone
URL:
Keywords: build
Depends on:
Blocks:
 
Reported: 2010-08-07 16:43 UTC by Andi Kleen
Modified: 2022-01-06 00:17 UTC (History)
2 users (show)

See Also:
Host: x86_64-linux
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2010-08-13 07:42:15

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andi Kleen 2010-08-07 16:43:27 UTC 
I noticed this while doing a coverage enabled build. The libcpp Makefile
doesn't enable the coverage options unlike the code in gcc/*

I think it also does not enable coverage for make profiled-bootstrap

This likely gives some compiler performance away.
Comment 1 Steven Bosscher 2010-08-13 07:42:15 UTC 
Does anyone have a daily autotester for profiled-bootstrap?
Comment 2 Richard Biener 2010-08-13 08:26:21 UTC 
No, we only have daily testers for SPEC 2000 with profile feedback.
Comment 3 Andrew Pinski 2022-01-04 04:48:37 UTC 
I looked into the makefiles and nothing has changed in them since 2007 with respect to profiledbootstrap. And I am double checking a "make profiledbootstrap" right now and will report back on the options passed to libcpp subdirectory.
Comment 4 Andrew Pinski 2022-01-04 05:46:12 UTC 
So -fprofile-generate is passed from the toplevel directory as expected.

/home/apinski/src/upstream-gcc/gcc/objdir1/./prev-gcc/xg++ -B/home/apinski/src/upstream-gcc/gcc/objdir1/./prev-gcc/ -B/usr/local/x86_64-pc-linux-gnu/bin/ -nostdinc++ -B/home/apinski/src/upstream-gcc/gcc/objdir1/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs -B/home/apinski/src/upstream-gcc/gcc/objdir1/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/home/apinski/src/upstream-gcc/gcc/objdir1/prev-x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu  -I/home/apinski/src/upstream-gcc/gcc/objdir1/prev-x86_64-pc-linux-gnu/libstdc++-v3/include  -I/home/apinski/src/upstream-gcc/gcc/libstdc++-v3/libsupc++ -L/home/apinski/src/upstream-gcc/gcc/objdir1/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs -L/home/apinski/src/upstream-gcc/gcc/objdir1/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs  -I../../libcpp -I. -I../../libcpp/../include -I../../libcpp/include  -g -O2 -fno-checking -gtoggle -fprofile-generate -W -Wall -Wno-narrowing -Wwrite-strings -Wmissing-format-attribute -pedantic -Wno-long-long -Werror -fno-exceptions -fno-rtti -I../../libcpp -I. -I../../libcpp/../include -I../../libcpp/include    -c -o charset.o -MT charset.o -MMD -MP -MF .deps/charset.Tpo ../../libcpp/charset.c

This has been true since profiledbootstrap was done.

>I noticed this while doing a coverage enabled build. 

What are the options you used to do a coverate enabled build?
Comment 5 Andi Kleen 2022-01-04 14:25:20 UTC 
I think it was the method from the info file.

But I can't quite remember. If you cannot reproduce it I guess it's ok to close. Maybe I made some mistake.
Comment 6 Andrew Pinski 2022-01-06 00:17:07 UTC 
Profiledbootstrap does profile libcpp for me so closing as works for me since it has been doing this for a long time now.