Bug 42786 - Athlon SSE3 and Fx processors not supported by configure
Summary: Athlon SSE3 and Fx processors not supported by configure
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: bootstrap (show other bugs)
Version: 4.5.0
: P3 enhancement
Target Milestone: 4.3.5
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-18 05:51 UTC by Felyza Wishbringer
Modified: 2010-01-21 20:31 UTC (History)
1 user (show)

See Also:
Host: i686-pc-linux
Target: i686-pc-linux
Build: i686-pc-linux
Known to work:
Known to fail:
Last reconfirmed: 2010-01-19 17:30:06


Attachments
Didn't have option on submission, its now attached. (806 bytes, patch)
2010-01-18 05:52 UTC, Felyza Wishbringer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felyza Wishbringer 2010-01-18 05:51:40 UTC
The athlon64-sse3, opteron-sse3, k8-sse3, and athlon-fx processors are supported in the code itself, however support for the sse3 series was missing, and the fx series was partially implemented in the configure scripts. 

This patch will add support for the sse3 series as well as correct the fx entry. 

Index: gcc/config.gcc
===================================================================
--- gcc/config.gcc	(revision 156000)
+++ gcc/config.gcc	(working copy)
@@ -1144,7 +1144,7 @@
 			tmake_file="${tmake_file} i386/t-linux64"
 			need_64bit_hwint=yes
 			case X"${with_cpu}" in
-			Xgeneric|Xatom|Xcore2|Xnocona|Xx86-64|Xamdfam10|Xbarcelona|Xk8|Xopteron|Xathlon64|Xathlon-fx)
+			Xgeneric|Xatom|Xcore2|Xnocona|Xx86-64|Xamdfam10|Xbarcelona|Xk8|Xopteron|Xathlon64|Xathlon-fx|Xathlon64-sse3|Xk8-sse3|Xopteron-sse3)
 				;;
 			X)
 				if test x$with_cpu_64 = x; then
@@ -1153,7 +1153,7 @@
 				;;
 			*)
 				echo "Unsupported CPU used in --with-cpu=$with_cpu, supported values:" 1>&2
-				echo "generic atom core2 nocona x86-64 amdfam10 barcelona k8 opteron athlon64 athlon-fx" 1>&2
+				echo "generic atom core2 nocona x86-64 amdfam10 barcelona k8 opteron athlon64 athlon-fx athlon64-sse3 k8-sse3 opteron-sse3" 1>&2
 				exit 1
 				;;
 			esac
@@ -1260,7 +1260,7 @@
 		need_64bit_hwint=yes
 		use_gcc_stdint=wrap
 		case X"${with_cpu}" in
-		Xgeneric|Xatom|Xcore2|Xnocona|Xx86-64|Xamdfam10|Xbarcelona|Xk8|Xopteron|Xathlon64|Xathlon-fx)
+		Xgeneric|Xatom|Xcore2|Xnocona|Xx86-64|Xamdfam10|Xbarcelona|Xk8|Xopteron|Xathlon64|Xathlon-fx|Xathlon64-sse3|Xk8-sse3|Xopteron-sse3)
 			;;
 		X)
 			if test x$with_cpu_64 = x; then
@@ -1269,7 +1269,7 @@
 			;;
 		*)
 			echo "Unsupported CPU used in --with-cpu=$with_cpu, supported values:" 1>&2
-			echo "generic atom core2 nocona x86-64 amdfam10 barcelona k8 opteron athlon64 athlon-fx" 1>&2
+			echo "generic atom core2 nocona x86-64 amdfam10 barcelona k8 opteron athlon64 athlon-fx athlon64-sse3 k8-sse3 opteron-sse3" 1>&2
 			exit 1
 			;;
 		esac
@@ -1339,7 +1339,7 @@
 			if test x$enable_targets = xall; then
 				tm_defines="${tm_defines} TARGET_BI_ARCH=1"
 				case X"${with_cpu}" in
-				Xgeneric|Xatom|Xcore2|Xnocona|Xx86-64|Xamdfam10|Xbarcelona|Xk8|Xopteron|Xathlon64|Xathlon-fx)
+				Xgeneric|Xatom|Xcore2|Xnocona|Xx86-64|Xamdfam10|Xbarcelona|Xk8|Xopteron|Xathlon64|Xathlon-fx|Xathlon64-sse3|Xk8-sse3|Xopteron-sse3)
 					;;
 				X)
 					if test x$with_cpu_64 = x; then
@@ -1348,7 +1348,7 @@
 					;;
 				*)
 					echo "Unsupported CPU used in --with-cpu=$with_cpu, supported values:" 1>&2
-					echo "generic atom core2 nocona x86-64 amdfam10 barcelona k8 opteron athlon64 athlon-fx" 1>&2
+					echo "generic atom core2 nocona x86-64 amdfam10 barcelona k8 opteron athlon64 athlon-fx athlon64-sse3 k8-sse3 opteron-sse3" 1>&2
 					exit 1
 					;;
 				esac
@@ -2629,8 +2629,11 @@
       case ${target_noncanonical} in
         amdfam10-*|barcelona-*)
           with_cpu=amdfam10
+          ;; 
+        k8_sse3-*|opteron_sse3-*|athlon64_sse3-*)
+          with_cpu=k8-sse3
           ;;
-        k8-*|opteron-*|athlon_64-*)
+        k8-*|opteron-*|athlon64-*|athlon_fx-*)
           with_cpu=k8
           ;;
         athlon_xp-*|athlon_mp-*|athlon_4-*)
@@ -2676,7 +2679,10 @@
         amdfam10-*|barcelona-*)
           with_cpu=amdfam10
           ;;
-        k8-*|opteron-*|athlon_64-*)
+        k8_sse3-*|opteron_sse3-*|athlon64_sse3-*)
+          with_cpu=k8-sse3
+          ;;
+        k8-*|opteron-*|athlon64-*|athlon_fx-*)
           with_cpu=k8
           ;;
         nocona-*)
@@ -2970,7 +2976,7 @@
 				esac
 				# OK
 				;;
-			"" | amdfam10 | barcelona | k8 | opteron | athlon64 | athlon-fx | nocona | core2 | atom | generic)
+			"" | amdfam10 | barcelona | k8-sse3 | opteron-sse3 | athlon64-sse3 | k8 | opteron | athlon64 | athlon-fx | nocona | core2 | atom | generic)
 				# OK
 				;;
 			*)
Comment 1 Felyza Wishbringer 2010-01-18 05:52:57 UTC
Created attachment 19644 [details]
Didn't have option on submission, its now attached.
Comment 2 Felyza Wishbringer 2010-01-18 05:54:33 UTC
Can't edit original post. Email client added line breaks where they shouldn't be. Please use patch attached to issue, and not one orginally submitted in description.
Comment 3 Uroš Bizjak 2010-01-19 17:30:06 UTC
(In reply to comment #2)
> Can't edit original post. Email client added line breaks where they shouldn't
> be. Please use patch attached to issue, and not one orginally submitted in
> description.

Please post the patch (with appropriate ChangeLog) to gcc-patches@gcc.gnu.org mailing list, as described in great detail in [1].

The patch is OK as far as x86 is concerned, but you will need an approval from build maintainer for these changes.  Please also note, that it is a bit late in the release process for these kind of changes, so unless you convince the maintainer of a great benefit from your patch, it will have to wait for 4.6 release.

[1] http://gcc.gnu.org/contribute.html
Comment 4 uros 2010-01-20 11:28:05 UTC
Subject: Bug 42786

Author: uros
Date: Wed Jan 20 11:27:49 2010
New Revision: 156071

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156071
Log:
	PR bootstrap/42786
	* config.gcc (i[34567]86-*-*): Fix handling of athlon64 and athlon-fx
	cpu types.  Add support for *-sse3 cpu types.
	(x86_64-*-*): Ditto.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config.gcc

Comment 5 uros 2010-01-21 20:04:13 UTC
Subject: Bug 42786

Author: uros
Date: Thu Jan 21 20:03:55 2010
New Revision: 156159

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156159
Log:
	PR bootstrap/42786
	* config.gcc (i[34567]86-*-*): Fix handling of athlon64 and athlon-fx
	cpu types.  Add support for *-sse3 cpu types.
	(x86_64-*-*): Ditto.


Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/config.gcc

Comment 6 uros 2010-01-21 20:10:21 UTC
Subject: Bug 42786

Author: uros
Date: Thu Jan 21 20:10:04 2010
New Revision: 156160

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156160
Log:
	PR bootstrap/42786
	* config.gcc (i[34567]86-*-*): Fix handling of athlon64 and athlon-fx
	cpu types.  Add support for *-sse3 cpu types.
	(x86_64-*-*): Ditto.


Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/config.gcc

Comment 7 Uroš Bizjak 2010-01-21 20:30:49 UTC
Fixed.