I just ran the most excellent sourceforge tool "cppcheck" over the source code of the GNU C compiler version 4.5 snapshot 20100107 and cppcheck said lots of things. An extract is below. [./libcpp/init.c:260]: (style) Redundant condition. It is safe to deallocate a NULL pointer [./libcpp/files.c:999]: (style) Redundant condition. It is safe to deallocate a NULL pointer [./libcpp/pch.c:725]: (style) Redundant condition. It is safe to deallocate a NULL pointer [./libcpp/pch.c:727]: (style) Redundant condition. It is safe to deallocate a NULL pointer [./libcpp/pch.c:729]: (style) Redundant condition. It is safe to deallocate a NULL pointer I've manually checked all of these and I agree with cppcheck - the redundant conditions may be safely deleted.
Didn't I tell you already that these issues are *not* suited for Bugzilla, because aren't user visible? Just mention the issue on gcc, or send a patch to gcc-patches.
With cppcheck-1.59 on Fedora 18 (x86_64) and gcc-4.8.0, the "Redundant condition" is not present.
(In reply to Shakthi Kannan from comment #2) > With cppcheck-1.59 on Fedora 18 (x86_64) and gcc-4.8.0, the "Redundant > condition" is not present. This probably got fixed on its own. Thanks anyway for reporting it.