Bug 42263 - Wrong code bugs in SMP support
Summary: Wrong code bugs in SMP support
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: target (show other bugs)
Version: 4.4.2
: P2 major
Target Milestone: 4.4.3
Assignee: Richard Earnshaw
URL:
Keywords: wrong-code
Depends on:
Blocks:
 
Reported: 2009-12-03 14:45 UTC by Richard Earnshaw
Modified: 2009-12-11 17:46 UTC (History)
1 user (show)

See Also:
Host:
Target: arm-none-linux-gnueabi
Build:
Known to work:
Known to fail:
Last reconfirmed: 2009-12-03 14:59:29


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Earnshaw 2009-12-03 14:45:26 UTC
There are two subtle wrong code bugs in the __sync_... primitives that severely affect code generation for linux.  Both of these have been fixed on trunk.

http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00198.html

http://gcc.gnu.org/ml/gcc-patches/2009-08/msg00600.html

but need back-porting to 4.4
Comment 1 Ramana Radhakrishnan 2009-12-10 15:23:09 UTC
Fixing target milestone and version reported against. 

cheers
Ramana
Comment 2 Ramana Radhakrishnan 2009-12-11 17:37:51 UTC
Subject: Bug 42263

Author: ramana
Date: Fri Dec 11 17:37:34 2009
New Revision: 155171

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155171
Log:
2009-12-11  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

	PR target/42263
	2009-08-11  Andrew Haley  <aph@redhat.com>
	* config/arm/arm.c (arm_init_libfuncs): Add __sync_synchronize.

Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/config/arm/arm.c

Comment 3 Ramana Radhakrishnan 2009-12-11 17:45:56 UTC
Subject: Bug 42263

Author: ramana
Date: Fri Dec 11 17:45:32 2009
New Revision: 155172

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155172
Log:
2009-12-11  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

	PR target/42263
	Backport from mainline

	2009-12-03  Richard Earnshaw  <rearnsha@arm.com>

	* arm/linux-atomic.c (SYNC_LOCK_RELEASE): Place memory barrier
	before the lock release.

Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/config/arm/linux-atomic.c

Comment 4 Ramana Radhakrishnan 2009-12-11 17:46:14 UTC
Fixed.